Skip to content

fix(llc): Reset reaction timer on new reaction #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

renefloor
Copy link
Contributor

@renefloor renefloor commented Jul 9, 2025

🎯 Goal

Fix reactions

🛠 Implementation details

Currently old timer is triggered even when there is a new reaction already. This cancels the old timer if there is any before creating a new one.

Implementation is now more similar to the _captionsTimers.

🎨 UI Changes

No relevant UI changes

🧪 Testing

I've tested it by quickly triggering reactions on old app and new app. In the old app after a couple of seconds all reactions are quickly removed, new app last one stays for couple of seconds.

☑️Contributor Checklist

General

  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of call reactions to prevent premature removal when users send multiple reactions quickly.
    • Enhanced reliability in managing reaction timers to ensure accurate reaction resets per user.

@renefloor renefloor requested a review from a team as a code owner July 9, 2025 08:53
Copy link

coderabbitai bot commented Jul 9, 2025

Walkthrough

The _reactionTimers field in the Call class was changed from a List<Timer> to a Map<String, Timer> keyed by user ID. Timer management logic was updated to cancel and replace timers per user, and the _clear method now iterates over map values to cancel timers.

Changes

File Change Summary
packages/stream_video/lib/src/call/call.dart Changed _reactionTimers from List<Timer> to Map<String, Timer>, updated timer management logic.
packages/stream_video/CHANGELOG.md Added unreleased changelog entry documenting a bug fix for reaction timer handling on rapid reactions.

Poem

In the meadow of code, timers once ran free,
Now each bunny gets their own, as neat as can be.
With a map for each friend, reactions are clear,
No timer confusion, just harmony here.
🕰️🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 698d577 and c9f68a8.

📒 Files selected for processing (1)
  • packages/stream_video/CHANGELOG.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/stream_video/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: stream_video_screen_sharing
  • GitHub Check: stream_video_push_notification
  • GitHub Check: stream_video
  • GitHub Check: stream_video_flutter
  • GitHub Check: stream_video_noise_cancellation
  • GitHub Check: analyze
  • GitHub Check: build
  • GitHub Check: analyze_legacy_version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@renefloor renefloor changed the title Reset reaction timer on new reaction fix(llc): Reset reaction timer on new reaction Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 4.16%. Comparing base (12e581c) to head (c9f68a8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/stream_video/lib/src/call/call.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1018      +/-   ##
========================================
- Coverage   4.17%   4.16%   -0.01%     
========================================
  Files        573     573              
  Lines      38513   38515       +2     
========================================
  Hits        1606    1606              
- Misses     36907   36909       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renefloor renefloor merged commit b8bba6a into main Jul 9, 2025
14 of 17 checks passed
@renefloor renefloor deleted the fix/reset-reaction-timers-on-new-reaction branch July 9, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants