fix(llc): ringing rejection fix when calling multiple devices

[Brazol]

When handling the call rejected event, we didn't consider participants who already joined the call. As a result, we could accidentally end the call when the last ringing device rejects.

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue where rejecting a ringing call by one participant would incorrectly end the call for all other participants. Now, rejecting a call only affects the participant who rejected, allowing others to continue ringing.
  • Improved call state handling to prevent potential errors when removing active calls.

[coderabbitai]

Walkthrough

This update refines the logic for handling call rejection during the ringing state in a video call system. It ensures that when one participant rejects a ringing call, the call continues for others still ringing. The changes include logic adjustments in state management and corresponding changelog updates.

Changes

File(s)	Change Summary
packages/stream_video/CHANGELOG.md packages/stream_video_flutter/CHANGELOG.md	Updated changelogs to document the fix for call rejection handling during ringing.
packages/stream_video/lib/src/call/state/mixins/state_coordinator_mixin.dart	Refined logic to determine when all participants have rejected a call, ensuring correct call state.
packages/stream_video/lib/src/core/client_state.dart	Improved null safety in removeActiveCall to avoid errors when removing inactive calls.

Suggested reviewers

• renefloor

Poem

A ring, a call, a bunny’s cheer,
Now one hops out, but others stay near.
No more abrupt ends for the group’s delight,
Each rabbit decides, in the soft moonlight.
With careful code, the calls persist—
Bugs now gone, let’s hop and twist! 🐇☎️

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f26cefa and 90aea7d.

📒 Files selected for processing (4)

• packages/stream_video/CHANGELOG.md (1 hunks)
• packages/stream_video/lib/src/call/state/mixins/state_coordinator_mixin.dart (1 hunks)
• packages/stream_video/lib/src/core/client_state.dart (1 hunks)
• packages/stream_video_flutter/CHANGELOG.md (1 hunks)

🧰 Additional context used

🪛 LanguageTool

packages/stream_video/CHANGELOG.md

[style] ~9-~9: Consider using a different verb for a more formal wording.
Context: ... the original cause of disconnection. * Fixed an issue where rejecting a ringing call...

(FIX_RESOLVE)

packages/stream_video_flutter/CHANGELOG.md

[style] ~22-~22: Consider using a different verb for a more formal wording.
Context: ... the original cause of disconnection. * Fixed an issue where rejecting a ringing call...

(FIX_RESOLVE)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: stream_video_push_notification
• GitHub Check: stream_video_noise_cancellation
• GitHub Check: stream_video_screen_sharing
• GitHub Check: stream_video
• GitHub Check: build
• GitHub Check: stream_video_flutter
• GitHub Check: analyze
• GitHub Check: analyze_legacy_version

🔇 Additional comments (4)

packages/stream_video/CHANGELOG.md (1)

9-9: LGTM! Clear and accurate bug fix documentation.

The changelog entry clearly describes the issue and resolution, making it easy for users to understand what was fixed.

packages/stream_video/lib/src/core/client_state.dart (1)

118-122: LGTM! Good defensive programming practice.

Adding the hasValue check prevents potential null access when activeCall is unset, improving the robustness of call state management.

packages/stream_video_flutter/CHANGELOG.md (1)

22-22: LGTM! Consistent documentation across packages.

The changelog entry matches the description in the core package, maintaining consistency in documentation.

packages/stream_video/lib/src/call/state/mixins/state_coordinator_mixin.dart (1)

95-98: LGTM! Critical logic fix correctly addresses the premature call termination bug.

The addition of state.otherParticipants.isEmpty && ensures that the call only ends when there are truly no other participants in the call, not just when all members have rejected. This prevents the scenario where a participant rejection would incorrectly terminate the call for others who had already joined.

The logic now correctly distinguishes between:

• Members who were invited but rejected (tracked in rejectedBy)
• Participants who have actually joined the call (tracked in otherParticipants)

This fix ensures calls continue properly for connected participants even when ringing members reject.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 4.17%. Comparing base (f26cefa) to head (90aea7d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...src/call/state/mixins/state_coordinator_mixin.dart	0.00%	4 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #1007   +/-   ##
=====================================
  Coverage   4.16%   4.17%           
=====================================
  Files        573     573           
  Lines      38513   38515    +2     
=====================================
+ Hits        1604    1607    +3     
+ Misses     36909   36908    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.