File tree Expand file tree Collapse file tree 2 files changed +20
-3
lines changed Expand file tree Collapse file tree 2 files changed +20
-3
lines changed Original file line number Diff line number Diff line change
1
+ ---
2
+ " scan-chart " : patch
3
+ ---
4
+
5
+ Prune unnecessary issues for short songs
Original file line number Diff line number Diff line change @@ -234,7 +234,10 @@ function findChartIssues(
234
234
} else {
235
235
const expertHash = trackHashes . find ( t => t . instrument === instrumentGroup [ 0 ] . instrument && t . difficulty === 'expert' ) ! . hash
236
236
for ( const track of instrumentGroup . filter ( t => t . difficulty !== 'expert' ) ) {
237
- if ( expertHash === trackHashes . find ( t => t . instrument === track . instrument && t . difficulty === track . difficulty ) ! . hash ) {
237
+ if (
238
+ expertHash === trackHashes . find ( t => t . instrument === track . instrument && t . difficulty === track . difficulty ) ! . hash &&
239
+ track . noteEventGroups . length > 20
240
+ ) {
238
241
addIssue ( track . instrument , track . difficulty , 'difficultyNotReduced' )
239
242
}
240
243
}
@@ -294,7 +297,11 @@ function findChartIssues(
294
297
295
298
// noStarPower
296
299
{
297
- if ( track . starPowerSections . length === 0 ) {
300
+ if (
301
+ track . starPowerSections . length === 0 &&
302
+ track . noteEventGroups . length > 50 &&
303
+ _ . last ( track . noteEventGroups ) ! [ 0 ] . msTime - _ . first ( track . noteEventGroups ) ! [ 0 ] . msTime > 60000
304
+ ) {
298
305
addIssue ( 'noStarPower' )
299
306
}
300
307
}
@@ -324,7 +331,12 @@ function findChartIssues(
324
331
325
332
// noDrumActivationLanes
326
333
{
327
- if ( track . instrument === 'drums' && track . drumFreestyleSections . length === 0 ) {
334
+ if (
335
+ track . instrument === 'drums' &&
336
+ track . drumFreestyleSections . length === 0 &&
337
+ track . noteEventGroups . length > 50 &&
338
+ _ . last ( track . noteEventGroups ) ! [ 0 ] . msTime - _ . first ( track . noteEventGroups ) ! [ 0 ] . msTime > 60000
339
+ ) {
328
340
addIssue ( 'noDrumActivationLanes' )
329
341
}
330
342
}
You can’t perform that action at this time.
0 commit comments