Fix noNotes bug

Geomitron · Geomitron · commit 3166de24a2ec · 2024-07-24T01:41:40.000-05:00
diff --git a/.changeset/late-cooks-hang.md b/.changeset/late-cooks-hang.md
@@ -0,0 +1,5 @@
+---
+"scan-chart": patch
+---
+
+Fix noNotes bug
diff --git a/src/chart/chart-scanner.ts b/src/chart/chart-scanner.ts
@@ -222,7 +222,7 @@ function findChartIssues(
 
 	// noNotes
 	{
-		if (chartData.trackData.every(track => track.noteEventGroups.length === 0)) {
+		if (chartData.trackData.every(track => track.noteEventGroups.length === 0) && !chartData.hasVocals) {
 			addIssue(null, null, 'noNotes')
 		}
 	}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"scan-chart": patch
 +---
++
 +Fix noNotes bug
Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ function findChartIssues(`
`222`	`222`
`223`	`223`	`// noNotes`
`224`	`224`	`{`
`225`		`- if (chartData.trackData.every(track => track.noteEventGroups.length === 0)) {`
	`225`	`+ if (chartData.trackData.every(track => track.noteEventGroups.length === 0) && !chartData.hasVocals) {`
`226`	`226`	`addIssue(null, null, 'noNotes')`
`227`	`227`	`}`
`228`	`228`	`}`