-
Notifications
You must be signed in to change notification settings - Fork 128
Open
Labels
enhancementAdding additional functionality or improvementsAdding additional functionality or improvementshelp wantedExtra attention is neededExtra attention is neededpinnedPrevents stalebot from removingPrevents stalebot from removingpriority: couldFuture work depending on bandwidth and availabilityFuture work depending on bandwidth and availability
Description
Hi team,
This is a really awesome tool and it's helped us reduce a lot of repeated binding specs.
I was wondering if it would be possible to add a way to specify for how long a RBACDefinition is valid for, and additionally, a "start date" to specify when the RBACDefinition will become valid. For example, it would be nice if we could do the following (extending the example on the README):
apiVersion: rbacmanager.reactiveops.io/v1beta1
kind: RBACDefinition
metadata:
name: dev-access
rbacBindings:
- name: dev-team
subjects:
- kind: Group
name: dev-team
roleBindings:
- clusterRole: edit
namespaceSelector:
matchLabels:
team: dev
# If startTime is omitted, then it is valid immediately
startTime: "2020-09-15T00:17:10Z"
# If endTime is omitted, then it is valid indefinitely
endTime: "2021-09-15T00:17:10Z"
Some use cases I had in mind were:
- Sometimes I want to give temporary access, and for that I could use some kind of
endTime
field - Perhaps I have a new employee that I know will need permissions at some point, I could specify a
startTime
so that I could apply the RBACDefinition now, but it's effect won't take place until later. Another example here is: I have an intern for which I know the exact time they start and end, so I could set up their roles to have a start and expiry date.
lucasreed, AndersNordin, snooyen, jmueller42, weisdd and 2 more
Metadata
Metadata
Assignees
Labels
enhancementAdding additional functionality or improvementsAdding additional functionality or improvementshelp wantedExtra attention is neededExtra attention is neededpinnedPrevents stalebot from removingPrevents stalebot from removingpriority: couldFuture work depending on bandwidth and availabilityFuture work depending on bandwidth and availability
Type
Projects
Status
No status
Milestone
Relationships
Development
Select code repository
Activity
sudermanjr commentedon Feb 19, 2021
This would be a really cool feature. I feel like it might be a significant change, but a very very cool feature.
stale commentedon Apr 13, 2021
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.