Refactoring v2 #110
Refactoring v2 #110
Conversation
…o 5.4 min. introduce guzzle http client. drop soap request.
adapt sample files.
adapt files for codemetrics.
change readme.
add exception thrown in generic configuration for invalid country.
add test for rest request.
|
Build success |
| * | ||
| * @var string | ||
| */ | ||
| private $requestScheme = "http://webservices.amazon.%s/onca/xml?%s"; |
There was a problem hiding this comment.
Would it be possible to use HTTPS instead of HTTP?
There was a problem hiding this comment.
What about if you can decide what to use?
e.g. this is set by default to http and you can set it via setter explicit to https.
setScheme('https');
There was a problem hiding this comment.
Would probably a good idea. But what about making this secure first by using HTTPS. If the user wants to use HTTP the setter can be used. But I wonder if this makes having the openssl-extension mandatory?
There was a problem hiding this comment.
At least if the client uses filegetcontents. I will make http as default since this is anyway a server to server communication. if a user want's to use https he can switch it in the request explicit.
|
Build success |
|
Build success |
|
Build success |
|
Build success |
|
Build success |
|
Switch the API version to 2013-08-01. |
|
Build success |
|
Build success |
|
Build success |
|
Build success |
|
Build success |
|
Build success |
| @@ -24,13 +24,16 @@ | |||
| use ApaiIO\Operations\CartCreate; | |||
|
|
|||
| $conf = new GenericConfiguration(); | |||
| $client = new \GuzzleHttp\Client(); | |||
| $request = new \ApaiIO\Request\Rest\Request($client); | |||
There was a problem hiding this comment.
I would declare the name of the request class into more specific one. The request is some kind a Adaptor for your library and therefore I would choose something like GuzzleRequest or similar.
|
Build success |
|
Build success |
|
Build success |
|
Build success |
|
Build success |
No description provided.