Design: Disable "Add device" if 2FA for a location is enabled

[FrancoLoyola]

Describe the bug
The user can still create a manual/vanilla WG config even if 2FA enforced.

This allows to connect without having to use TOTP

To Reproduce
Steps to reproduce the behavior:

1. Create a location with required MFA
2. Add some user
3. Add TOTP to the user
4. Add a new device
5. Create a manual WG client
6. User can connect without using TOTP

Expected behavior
That users cannot connect without using TOTP -> Do not allow to add vanilla WG configs

Version information

• Defguard Core version: v0.9.0
• On any browser

Screenshots

Additional context
I'm not familiar with React (or ts/js at all), but it seems to me that having some sort of check in:

defguard/web/src/pages/addDevice/steps/AddDeviceSetupMethodStep/AddDeviceSetupMethodStep.tsx

Line 94 in c6f2d94

<DeviceSetupMethodCard

to not show the card if MFA is enabled should work.

Maybe a cleaner approach is just to skip to the next step if MFA is required with the "remote desktop activation" already selected for you and skip that step altogether

[teon]

@FrancoLoyola for sure user cannot connect to the VPN. Can configure - but can't connect.
@filipslezaklab we should just disable Wireguard manual setup for the MFA VPNs.

[FrancoLoyola]

Thanks for the quick reply! Looking forward to the update!

[SkullKill]

@teon Sort of related, but we would like to have the option to disable the option for the user to provision their own VPN (both defguard and native wireguard).

So , an option to completely disable the "Add a new device" option for users. And only allow the Admins to generate a token for the user to use to provision their defguard clients.

Not sure if you want me to open a new ticket for this?

[teon]

@SkullKill yap, that is another issue - please open a new issue and describe your requirements.

[teon]

@filipslezaklab allow configuring a device manually:

1. If number of VPNs user is allowed to and they are not MFA >= 1
2. Do not show MFA based configurations

[teon]

Related to #596