Added Git URLs, dropped EHRFM & V3 product families, filled in a bunch of missing ciBuilds, added QA checks for appropriate population of ciBuild, git, ballot and main URLs, and fixed a bunch of issues where URLs were incorrect.

Author: lmckenzi

FHIR-saner.xml

@@ -147,6 +147,11 @@
           <xs:documentation>The URL for the current/most recent ballot of this specification.  Used when validating URLs</xs:documentation>
         </xs:annotation>
       </xs:attribute>
+      <xs:attribute name="gitUrl" type="website" use="optional">
+        <xs:annotation>
+          <xs:documentation>The base URL for the repository in which the source material for this specificaiton is maintained.</xs:documentation>
+        </xs:annotation>
+      </xs:attribute>
       <xs:attribute name="defaultWorkgroup" type="WorkGroup" use="optional">
         <xs:annotation>
           <xs:documentation>The work group typically associated with issues raised against this specification if a more specific work group isn't determined based on pages or artifacts</xs:documentation>

schemas/specification.xsd

@@ -16,7 +16,7 @@
       <xsl:variable name="filename" select="concat('SPECS-', @key, '.xml')"/>
       <xsl:variable name="specs" select="document($filename, .)/specifications" as="element(specifications)?"/>
       <xsl:if test="not($specs)">
-        <xsl:message terminate="yes" select="concat('Unable to find specifications for family ', @key, ' - looking for file ', $filename)"/>
+        <xsl:message terminate="yes" select="concat('ERROR: Unable to find specifications for family ', @key, ' - looking for file ', $filename)"/>
       </xsl:if>
       <xsl:apply-templates mode="familySpecs" select="$specs">
         <xsl:with-param name="prefix" select="@key" tunnel="yes"/>
@@ -68,15 +68,15 @@
 	<xsl:template mode="familySpecs" match="specifications/specification">
     <xsl:param name="prefix" tunnel="yes"/>
     <xsl:for-each select="page/@url[.=ancestor::specification/page/otherpage/@url]">
-      <xsl:message terminate="yes" select="concat('The same name is present in both page/@url and page/otherpage/@url: ', .)"/>
+      <xsl:message terminate="yes" select="concat('ERROR: The same name is present in both page/@url and page/otherpage/@url: ', .)"/>
     </xsl:for-each>
     <xsl:copy>
       <xsl:apply-templates mode="familySpecs" select="@*"/>
       <xsl:variable name="filename" select="concat($prefix, '-', @key, '.xml')"/>
       <xsl:variable name="spec" select="document($filename, .)/specification" as="element(specification)?"/>
       <xsl:variable name="specKey" select="@key"/>
       <xsl:if test="not($spec)">
-        <xsl:message terminate="yes" select="concat('Unable to find specification ', @name, ' - looking for file ', $filename)"/>
+        <xsl:message terminate="yes" select="concat('ERROR: Unable to find specification ', @name, ' - looking for file ', $filename)"/>
       </xsl:if>
       <xsl:for-each select="$spec">
         <xsl:apply-templates mode="familySpecs" select="@*|node()">
@@ -92,13 +92,13 @@
     <xsl:choose>
       <xsl:when test="@deprecated='true' or self::page"/>
       <xsl:when test="not(@id)">
-        <xsl:message terminate="yes" select="concat('id attribute is mandatory for artifacts that are not deprecated - ', $key)"/>
+        <xsl:message terminate="yes" select="concat('ERROR: id attribute is mandatory for artifacts that are not deprecated - ', $key)"/>
       </xsl:when>
       <xsl:when test="contains($prefix, 'FHIR') and not(matches(string(@id), '^([A-Z][a-z]+)+/[A-Za-z0-9\-\.]{1,64}$'))">
-        <xsl:message terminate="yes" select="concat('In FHIR artifact ', $key, ', id value of ', @id, ' does not follow the pattern ResourceName/id')"/>
+        <xsl:message terminate="yes" select="concat('ERROR: In FHIR artifact ', $key, ', id value of ', @id, ' does not follow the pattern ResourceName/id')"/>
       </xsl:when>
       <xsl:when test="contains($prefix, 'CDA') and not(matches(@id, '^[0-2](\.(0|[1-9][0-9]*))+$'))">
-        <xsl:message terminate="yes" select="concat('In CDA artifact ', $key, ', id value of ', @id, ' is not an OID', matches(@id, '^[0-2](\\.(0|[1-9][0-9]*))+$'))"/>
+        <xsl:message terminate="yes" select="concat('ERROR: In CDA artifact ', $key, ', id value of ', @id, ' is not an OID', matches(@id, '^[0-2](\\.(0|[1-9][0-9]*))+$'))"/>
       </xsl:when>
     </xsl:choose>    
     <xsl:copy>
@@ -123,28 +123,77 @@
     - Main process
     -->
 	<xsl:template match="/">
+    <!-- Check cross-specification validation rules -->
+    <xsl:for-each select="$ballotSpecs/specification[not(starts-with(@gitUrl, 'https://github.com/HL7/')) and not(@deprecated='true') and starts-with(@key, 'FHIR-')]">
+      <xsl:message terminate="yes" select="concat('ERROR: FHIR specifications that are not deprecated must have a gitUrl attribute that starts with ''https://github.com/HL7/'' ', @key)"/>
+    </xsl:for-each>
+    <xsl:for-each select="$ballotSpecs/specification[not(starts-with(@ciUrl, 'http://build.fhir.org')) and not(@deprecated='true') and starts-with(@key, 'FHIR-')]">
+      <xsl:message select="concat('WARNING: FHIR specifications that are not deprecated SHOULD have a ciUrl attribute that starts with ''http://build.fhir.org'' ', @key, ' - actual was: ', @ciUrl)"/>
+    </xsl:for-each>
+    <xsl:for-each select="$ballotSpecs/specification[not(starts-with(@url, 'http://hl7.org/fhir')) and not(@deprecated='true') and starts-with(@key, 'FHIR-')]">
+      <xsl:message select="concat('WARNING: FHIR specifications that are not deprecated SHOULD have a url attribute that starts with ''http://hl7.org/fhir'' ', @key, ' - actual was: ', @url)"/>
+    </xsl:for-each>
+    <xsl:for-each select="$ballotSpecs/specification[@ballotUrl and not(starts-with(@ballotUrl, 'http://hl7.org/'))]">
+      <xsl:message terminate="yes" select="concat('ERROR: If present, ballotUrl must start with ''http://hl7.org/'' ', @key, ' - actual was: ', @ballotUrl)"/>
+    </xsl:for-each>
+    <xsl:for-each select="distinct-values($ballotSpecs/specification/@gitUrl)">
+      <xsl:if test="count($ballotSpecs/specification[@gitUrl=current()])!=1">
+        <xsl:variable name="dupSpecs" select="string-join($ballotSpecs/specification[@gitUrl=current()]/@key, ', ')"/>
+        <xsl:message select="concat('WARNING: Multiple FHIR specifications with the same gitUrl of ''', ., ''': ', $dupSpecs)"/>
+      </xsl:if>
+    </xsl:for-each>
+    <xsl:for-each select="$ballotSpecs/specification[@gitUrl[not(starts-with(., 'https://github.com/'))]]">
+      <xsl:message select="concat('ERROR: GitUrl for specification ', @key, ' must start with ''https://github.com/'': ', @gitUrl)"/>
+    </xsl:for-each>
+    <xsl:for-each select="$ballotSpecs/specification[@gitUrl[not(starts-with(., 'https://github.com/HL7/'))]]">
+      <xsl:message select="concat('WARNING: GitUrl for specification ', @key, ' SHOULD must start with ''https://github.com/HL7/'': ', @gitUrl)"/>
+    </xsl:for-each>
+    <xsl:for-each select="distinct-values($ballotSpecs/specification/@url)">
+      <xsl:if test="count($ballotSpecs/specification[@url=current()])!=1">
+        <xsl:variable name="dupSpecs" select="string-join($ballotSpecs/specification[@url=current()]/@key, ', ')"/>
+        <xsl:message terminate="yes" select="concat('ERROR: Multiple FHIR specifications with the same url of ''', ., ''': ', $dupSpecs)"/>
+      </xsl:if>
+    </xsl:for-each>
+    <xsl:for-each select="distinct-values($ballotSpecs/specification/@ciUrl)">
+      <xsl:if test="count($ballotSpecs/specification[@ciUrl=current()])!=1">
+        <xsl:variable name="dupSpecs" select="string-join($ballotSpecs/specification[@ciUrl=current()]/@key, ', ')"/>
+        <xsl:message terminate="yes" select="concat('ERROR: Multiple FHIR specifications with the same ciUrl of ''', ., ''': ', $dupSpecs)"/>
+      </xsl:if>
+    </xsl:for-each>
+    <xsl:for-each select="distinct-values($ballotSpecs/specification/@ballotUrl)">
+      <xsl:if test="count($ballotSpecs/specification[@ballotUrl=current()])!=1">
+        <xsl:variable name="dupSpecs" select="string-join($ballotSpecs/specification[@ballotUrl=current()]/@key, ', ')"/>
+        <xsl:message terminate="yes" select="concat('ERROR: Multiple FHIR specifications with the same ballotUrl of ''', ., ''': ', $dupSpecs)"/>
+      </xsl:if>
+    </xsl:for-each>
+    <xsl:for-each select="distinct-values($ballotSpecs/specification/@ballotUrl)">
+      <xsl:if test="count($ballotSpecs/specification[@ballotUrl=current()])!=1">
+        <xsl:variable name="dupSpecs" select="string-join($ballotSpecs/specification[@ballotUrl=current()]/@key, ', ')"/>
+        <xsl:message terminate="yes" select="concat('ERROR: Multiple FHIR specifications with the same ballotUrl of ''', ., ''': ', $dupSpecs)"/>
+      </xsl:if>
+    </xsl:for-each>
     <!-- Check to see if any keys have been removed or changed -->
     <xsl:for-each select="$oldSpecs/specification">
       <xsl:variable name="newSpec" select="$ballotSpecs/specification[@key=current()/@key]" as="element(specification)?"/>
       <xsl:if test="not($newSpec)">
-        <xsl:message terminate="yes" select="concat('Specification with effective key ', @key, ' has been removed or changed.  Keys should never change - just change the name.  Keys should also not usually be removed.  Instead, set the ''deprecated'' flag to true.  Keys can only be removed if no JIRA tracker references that specification.  If this is the case and the key should really be removed, please coordinate with an administrator.')"/>
+        <xsl:message terminate="yes" select="concat('ERROR: Specification with effective key ', @key, ' has been removed or changed.  Keys should never change - just change the name.  Keys should also not usually be removed.  Instead, set the ''deprecated'' flag to true.  Keys can only be removed if no JIRA tracker references that specification.  If this is the case and the key should really be removed, please coordinate with an administrator.')"/>
       </xsl:if>
       <xsl:for-each select="version">
         <xsl:variable name="newVersion" select="$newSpec/version[@code=current()/@code]" as="element(version)?"/>
         <xsl:if test="not($newVersion)">
-          <xsl:message terminate="yes" select="concat('Version with code ', @code, ' in specification ', parent::specification/@key, ' has been removed or changed.  Versions should never change.  Keys should also not be removed.  Versions can only be removed if no JIRA tracker references that version.  If this is the case and the version should really be removed, please coordinate with an administrator.')"/>
+          <xsl:message terminate="yes" select="concat('ERROR: Version with code ', @code, ' in specification ', parent::specification/@key, ' has been removed or changed.  Versions should never change.  Keys should also not be removed.  Versions can only be removed if no JIRA tracker references that version.  If this is the case and the version should really be removed, please coordinate with an administrator.')"/>
         </xsl:if>
       </xsl:for-each>
       <xsl:for-each select="artifact">
         <xsl:variable name="newArtifact" select="$newSpec/artifact[@key=current()/@key]" as="element(artifact)?"/>
         <xsl:if test="not($newArtifact)">
-          <xsl:message terminate="yes" select="concat('Artifact with key ', @key, ' in specification ', parent::specification/@key, ' has been removed or changed.  Keys should never change - just change the name.  Keys should also not usually be removed.  Instead, set the ''deprecated'' flag to true.  Keys can only be removed if no JIRA tracker references that artifact.  If this is the case and the key should really be removed, please coordinate with an administrator.')"/>
+          <xsl:message terminate="yes" select="concat('ERROR: Artifact with key ', @key, ' in specification ', parent::specification/@key, ' has been removed or changed.  Keys should never change - just change the name.  Keys should also not usually be removed.  Instead, set the ''deprecated'' flag to true.  Keys can only be removed if no JIRA tracker references that artifact.  If this is the case and the key should really be removed, please coordinate with an administrator.')"/>
         </xsl:if>
       </xsl:for-each>
       <xsl:for-each select="page">
         <xsl:variable name="newPage" select="$newSpec/page[@key=current()/@key]" as="element(page)?"/>
         <xsl:if test="not($newPage)">
-          <xsl:message terminate="yes" select="concat('Page with key ', @key, ' in specification ', parent::specification/@key, ' has been removed or changed.  Keys should never change - just change the name.  Keys should also not usually be removed.  Instead, set the ''deprecated'' flag to true.  Keys can only be removed if no JIRA tracker references that page.  If this is the case and the key should really be removed, please coordinate with an administrator.')"/>
+          <xsl:message terminate="yes" select="concat('ERROR: Page with key ', @key, ' in specification ', parent::specification/@key, ' has been removed or changed.  Keys should never change - just change the name.  Keys should also not usually be removed.  Instead, set the ''deprecated'' flag to true.  Keys can only be removed if no JIRA tracker references that page.  If this is the case and the key should really be removed, please coordinate with an administrator.')"/>
         </xsl:if>
       </xsl:for-each>
     </xsl:for-each>

tools/buildCombinedSpecs.xslt

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<specification url="http://hl7.org/fhir/uv/bulkdata" defaultWorkgroup="fhir-i" defaultVersion="1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../schemas/specification.xsd">
+<specification gitUrl="https://github.com/HL7/bulk-data" url="http://hl7.org/fhir/uv/bulkdata" ciUrl="http://build.fhir.org/ig/HL7/bulk-data-export" defaultWorkgroup="fhir-i" defaultVersion="1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../schemas/specification.xsd">
   <version code="2.0.0"/>
   <version code="1.0.0"/>
   <version code="0.1" deprecated="true"/>

tools/buildSpecJSON.xslt

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<specification url="http://hl7.org/fhir/uv/cdisc-lab" defaultWorkgroup="brr" defaultVersion="0.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../schemas/specification.xsd">
+<specification gitUrl="https://github.com/HL7/cdisc-lab" url="http://hl7.org/fhir/uv/cdisc-lab" ciUrl="http://build.fhir.org/ig/HL7/cdisc-lab" defaultWorkgroup="brr" defaultVersion="0.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../schemas/specification.xsd">
   <version code="0.1"/>
   <artifactPageExtension value="-definitions"/>
   <artifactPageExtension value="-examples"/>

xml/EHRFM-core.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<specification url="https://cds-hooks.hl7.org/hooks/patient-view" ciUrl="http://cds-hooks.org/hooks/patient-view" defaultWorkgroup="cds" defaultVersion="1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../schemas/specification.xsd">
+<specification gitUrl="https://github.com/HL7/cds-hooks-hl7-site" url="https://cds-hooks.hl7.org/hooks/patient-view" ciUrl="http://cds-hooks.org/hooks/patient-view" defaultWorkgroup="cds" defaultVersion="1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../schemas/specification.xsd">
   <version code="1.0"/>
   <artifact name="Definition" key="Definition" deprecated="true"/>
   <page name="index" key="index"/>

xml/FHIR-bulkdata.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<specification url="http://cds-hooks.hl7.org" ciUrl="http://cds-hooks.org" defaultWorkgroup="cds" defaultVersion="1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../schemas/specification.xsd">
+<specification url="http://cds-hooks.hl7.org" gitUrl="https://github.com/HL7/cds-hooks-hl7-site" ciUrl="http://cds-hooks.org" defaultWorkgroup="cds" defaultVersion="1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../schemas/specification.xsd">
   <version code="1.0"/>
   <artifact name="Conformance" key="Conformance" deprecated="true"/>
   <page name="(NA)" key="NA"/>