Skip to content

Remap methods and properties #928

@Edouard127

Description

@Edouard127

On the latest build of recaf, applying tinyv2 mappings will only remap class names and not methods or properties

Activity

Col-E

Col-E commented on Apr 4, 2025

@Col-E
Owner

Please provide a sample & mappings file that reproduces the issue

Edouard127

Edouard127 commented on Apr 4, 2025

@Edouard127
Author

Please provide a sample & mappings file that reproduces the issue

mappings.txt
(renamed to .txt)
tiny mappings srg->mcp minecraft 1.7.10

I don't have a sample on hands, any mc mod for 1.7.10 will do it

Edouard127

Edouard127 commented on Apr 4, 2025

@Edouard127
Author

Log output

Applied mapping to 748 classes
Applied mappings from mappings.tiny - Updated 748 classes

No mentions of remapping methods or properties, check the class files, only classes are remapped

Image

luiox

luiox commented on Apr 18, 2025

@luiox
Contributor

I have tried using Recaf to remap the mod of 1.20.4, and the mapping table is of tiny v2. I didn't find any particular problems. remap is perfect. If you say it's version 1.7.10 of minecraft, then it might not be a mapping table in the Tiny v2 format. The mapping table of forge is in srg format.

Edouard127

Edouard127 commented on Apr 18, 2025

@Edouard127
Author

Class names are remapped correctly but method and fields that are present in the tinyv2 file are not remapped in places where they are called

Edouard127

Edouard127 commented on Apr 18, 2025

@Edouard127
Author

I have used the mappings viewer from wagyourtail to generate the mappings

luiox

luiox commented on Apr 19, 2025

@luiox
Contributor

Can you provide a mapping table and jar? I would like to try reproducing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Missing detailsNeeds more info to understand the problem

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Col-E@Edouard127@luiox

        Issue actions

          Remap methods and properties · Issue #928 · Col-E/Recaf