Merge branch 'ping-identity-home-account-refresh' of https://github.com/yowl/microsoft-authentication-library-for-dotnet into ping-identity-home-account-refresh

Author: scott.waye@hubse.net

build/template-pack-and-sign-all-nugets.yaml

@@ -44,12 +44,12 @@ steps:
     ProjectRootPath: '$(Build.SourcesDirectory)\$(MsalSourceDir)src\client'
     AssemblyName: 'Microsoft.Identity.Client.Extensions.Msal'
 
-# Sign binary and pack Microsoft.Identity.Client.MtlsPop
+# Sign binary and pack Microsoft.Identity.Client.KeyAttestation
 - template: template-pack-and-sign-nuget.yaml
   parameters:
     BuildConfiguration: ${{ parameters.BuildConfiguration }}
     ProjectRootPath: '$(Build.SourcesDirectory)\$(MsalSourceDir)src\client'
-    AssemblyName: 'Microsoft.Identity.Client.MtlsPop'
+    AssemblyName: 'Microsoft.Identity.Client.KeyAttestation'
 
 # Copy all packages out to staging
 - task: CopyFiles@2

tests/Microsoft.Identity.Test.LabInfrastructure/CertificateHelper.cs

@@ -2,8 +2,8 @@
 // Licensed under the MIT License.
 
 using System;
+using System.Runtime.InteropServices;
 using System.Security.Cryptography.X509Certificates;
-using Microsoft.Identity.Client.Extensions.Msal;
 
 namespace Microsoft.Identity.Test.LabInfrastructure
 {
@@ -39,7 +39,7 @@ public static X509Certificate2 FindCertificateByName(string subjectName)
         private static X509Certificate2 FindCertificateByName(string certName, StoreLocation location, StoreName name)
         {
             // Unix LocalMachine X509Store is limited to the Root and CertificateAuthority stores
-            if (SharedUtilities.IsLinuxPlatform())
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
             {
                 var certPasswrod = Environment.GetEnvironmentVariable("CERTIFICATE_PASSWORD");
                 var certLocation = Environment.GetEnvironmentVariable("CERTIFICATE_LOCATION");

tests/Microsoft.Identity.Test.LabInfrastructure/LabAuthenticationHelper.cs

@@ -8,8 +8,6 @@
 using System.Threading.Tasks;
 using Azure.Core;
 using Microsoft.Identity.Client;
-using Microsoft.Identity.Test.Unit;
-using Microsoft.Identity.Test.Common.Core.Mocks;
 
 namespace Microsoft.Identity.Test.LabInfrastructure
 {
@@ -19,7 +17,12 @@ public static class LabAuthenticationHelper
         public const string LabScope = "https://request.msidlab.com/.default";
         public const string LabClientInstance = "https://login.microsoftonline.com/";
         public const string LabClientTenantId = "72f988bf-86f1-41af-91ab-2d7cd011db47";
-
+        
+        /// <summary>
+        /// Certificate name for Microsoft Identity lab authentication. 
+        /// This certificate is used for automated testing and is available only to Microsoft employees.
+        /// </summary>
+        private const string AutomationTestCertName = "LabAuth.MSIDLab.com";
         public static async Task<AccessToken> GetAccessTokenForLabAPIAsync(string labAccessClientId)
         {
             string[] scopes = new string[] { LabScope };
@@ -44,9 +47,9 @@ public static async Task<AccessToken> GetLabAccessTokenAsync(string authority, s
             IConfidentialClientApplication confidentialApp;
             X509Certificate2 cert;
 
-            var clientIdForCertAuth = String.IsNullOrEmpty(clientId) ? LabAccessConfidentialClientId : clientId;
+            var clientIdForCertAuth = string.IsNullOrEmpty(clientId) ? LabAccessConfidentialClientId : clientId;
 
-            cert = CertificateHelper.FindCertificateByName(TestConstants.AutomationTestCertName);
+            cert = CertificateHelper.FindCertificateByName(AutomationTestCertName);
             if (cert == null)
             {
                 throw new InvalidOperationException(

tests/Microsoft.Identity.Test.LabInfrastructure/LabResponseHelper.cs

@@ -15,8 +15,8 @@ public static class LabResponseHelper
         public static KeyVaultSecretsProvider KeyVaultSecretsProviderMsid { get; }
 
         // Caches for configuration objects retrieved from Key Vault
-        private static readonly System.Collections.Concurrent.ConcurrentDictionary<string, UserConfig> s_userConfigCache = new();
-        private static readonly System.Collections.Concurrent.ConcurrentDictionary<string, AppConfig> s_appConfigCache = new();
+         private static readonly System.Collections.Concurrent.ConcurrentDictionary<string, UserConfig> s_userConfigCache = new System.Collections.Concurrent.ConcurrentDictionary<string, UserConfig>();
+        private static readonly System.Collections.Concurrent.ConcurrentDictionary<string, AppConfig> s_appConfigCache = new System.Collections.Concurrent.ConcurrentDictionary<string, AppConfig>();
 
         static LabResponseHelper()
         {