Skip to content

Commit 0e7b12a

Browse files
CopilotbgavrilMS
andauthored
Remove experimental flag requirement from IAuthenticationOperation (#5699)
* Initial plan * Remove experimental flag from IAuthenticationOperation and WithAuthenticationExtension Co-authored-by: bgavrilMS <12273384+bgavrilMS@users.noreply.github.com> * Update AuthenticationOperationTests to remove experimental flag requirement Co-authored-by: bgavrilMS <12273384+bgavrilMS@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bgavrilMS <12273384+bgavrilMS@users.noreply.github.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com>
1 parent 022762b commit 0e7b12a

File tree

3 files changed

+0
-6
lines changed

3 files changed

+0
-6
lines changed

src/client/Microsoft.Identity.Client/ApiConfig/AbstractAcquireTokenParameterBuilder.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,6 @@ public T WithB2CAuthority(string authorityUri)
343343

344344
internal /* for testing */ T WithAuthenticationOperation(IAuthenticationOperation authOperation)
345345
{
346-
ValidateUseOfExperimentalFeature();
347346
CommonParameters.AuthenticationOperation = authOperation ?? throw new ArgumentNullException(nameof(authOperation));
348347
return this as T;
349348
}

src/client/Microsoft.Identity.Client/Extensibility/AbstractConfidentialClientAcquireTokenParameterBuilderExtension.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,6 @@ public static AbstractAcquireTokenParameterBuilder<T> WithAdditionalCacheParamet
117117
return builder;
118118
}
119119

120-
builder.ValidateUseOfExperimentalFeature();
121-
122120
//Check if the cache parameters are already initialized, if so, add to the existing list
123121
if (builder.CommonParameters.AdditionalCacheParameters != null)
124122
{

tests/Microsoft.Identity.Test.Unit/AuthExtension/AuthenticationOperationTests.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ public async Task Should_UseCustomRequestHeaders_And_StoreAdditionalParameters()
2929
ConfidentialClientApplicationBuilder.Create(TestConstants.ClientId)
3030
.WithClientSecret(TestConstants.ClientSecret)
3131
.WithHttpManager(httpManager)
32-
.WithExperimentalFeatures(true)
3332
.BuildConcrete();
3433

3534
HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, new Uri(ProtectedUrl));
@@ -78,7 +77,6 @@ public async Task Should_UseCustomRequestHeaders_And_StoreAdditionalParametersWi
7877
ConfidentialClientApplicationBuilder.Create(TestConstants.ClientId)
7978
.WithClientSecret(TestConstants.ClientSecret)
8079
.WithHttpManager(httpManager)
81-
.WithExperimentalFeatures(true)
8280
.BuildConcrete();
8381

8482
HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, new Uri(ProtectedUrl));
@@ -158,7 +156,6 @@ public async Task Should_UseEmptyExtension_And_Parameters()
158156
ConfidentialClientApplicationBuilder.Create(TestConstants.ClientId)
159157
.WithClientSecret(TestConstants.ClientSecret)
160158
.WithHttpManager(httpManager)
161-
.WithExperimentalFeatures(true)
162159
.BuildConcrete();
163160

164161
HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, new Uri(ProtectedUrl));

0 commit comments

Comments
 (0)