From 31e17628ef3a4ab80a178b98f9302051e2bad600 Mon Sep 17 00:00:00 2001 From: Shahzaib Date: Sat, 15 Apr 2023 18:52:55 -0700 Subject: [PATCH 1/2] Remove application name from telemetry --- .../common/java/commands/InteractiveTokenCommand.java | 1 - .../identity/common/java/commands/SilentTokenCommand.java | 1 - .../identity/common/java/opentelemetry/AttributeName.java | 5 ----- 3 files changed, 7 deletions(-) diff --git a/common4j/src/main/com/microsoft/identity/common/java/commands/InteractiveTokenCommand.java b/common4j/src/main/com/microsoft/identity/common/java/commands/InteractiveTokenCommand.java index c4c5b3170c..644f8b069b 100644 --- a/common4j/src/main/com/microsoft/identity/common/java/commands/InteractiveTokenCommand.java +++ b/common4j/src/main/com/microsoft/identity/common/java/commands/InteractiveTokenCommand.java @@ -67,7 +67,6 @@ public AcquireTokenResult execute() throws Exception { final Span span = OTelUtility.createSpanFromParent( SpanName.AcquireTokenInteractive.name(), getParameters().getSpanContext() ); - span.setAttribute(AttributeName.application_name.name(), getParameters().getApplicationName()); span.setAttribute(AttributeName.public_api_id.name(), getPublicApiId()); try (final Scope scope = span.makeCurrent()) { diff --git a/common4j/src/main/com/microsoft/identity/common/java/commands/SilentTokenCommand.java b/common4j/src/main/com/microsoft/identity/common/java/commands/SilentTokenCommand.java index b88cec2c63..d159e6b830 100644 --- a/common4j/src/main/com/microsoft/identity/common/java/commands/SilentTokenCommand.java +++ b/common4j/src/main/com/microsoft/identity/common/java/commands/SilentTokenCommand.java @@ -74,7 +74,6 @@ public AcquireTokenResult execute() throws Exception { final Span span = OTelUtility.createSpanFromParent( SpanName.AcquireTokenSilent.name(), getParameters().getSpanContext() ); - span.setAttribute(AttributeName.application_name.name(), getParameters().getApplicationName()); span.setAttribute(AttributeName.public_api_id.name(), getPublicApiId()); try (final Scope scope = span.makeCurrent()) { diff --git a/common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java b/common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java index 7dfa1057c4..4399a086f5 100644 --- a/common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java +++ b/common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java @@ -105,11 +105,6 @@ public enum AttributeName { */ controller_name, - /** - * The name of the application making the request. - */ - application_name, - /** * Indicates if token was return from token cache */ From d6b660243b4afced1f36841230869bcd6fb0d9ed Mon Sep 17 00:00:00 2001 From: Shahzaib Date: Sat, 15 Apr 2023 18:54:56 -0700 Subject: [PATCH 2/2] Update changelog.txt --- changelog.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/changelog.txt b/changelog.txt index 684ecf3fc0..fb414a6521 100644 --- a/changelog.txt +++ b/changelog.txt @@ -3,6 +3,7 @@ V.NEXT - [PATCH] Fix Error Type thrown for NO_ACCOUNT_FOUND (#2006) - [PATCH] Pulling device cert issuer check to beginning of OnReceivedClientCertRequest (#2010) - [MINOR] Add method to clear receiver concurrentHashMap in LocalBroadcaster (#1993) +- [MINOR] Remove (dupe) application name from telemetry (#2011) V.11.0.0 ----------