Websocketのスキーマを作成 #177
Merged
Websocketのスキーマを作成 #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI落ちているのはOpenapi側のvalidationが落ちているからなのでいずれ誰かが修正するやつです |
Closed
woodnx
approved these changes
Jul 17, 2025
hikuohiku
force-pushed
the
feature/websocket-schema
branch
from
3be89a7 to
0d7e750
Compare
|
lintのCI落ちてますがopenapiの部分なので一度マージします。こちらで対応PR出します |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
websocketのスキーマ作りました。
OrderとDonの二つチャンネル作ったけど、Donの方はいらないかもしれない。
一つ気づいたことがあって、状態はDB的にはdonについてのみ定義していてそれで良さそうだけど、
ドメイン的にはorderにも状態があった方が良さそう（order単位で状態を考える場面が結構ありそう）です。
あとopenapiとasyncapiのドキュメントをgithub pagesで見れるようになるactionsも追加しました
ここからUIで見れます：https://studio.asyncapi.com/?share=7e6d3ded-ab7d-4897-820e-9948b3c8f396