ドメインモデル精査 #174
Merged
ドメインモデル精査 #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refines the domain model by migrating primary keys to UUIDs and restructuring the topping customization relations.
- Switched
ordersanddonsmodels to use UUID string IDs and renamed timestamp fields. - Introduced
customizesandcustomize_pricesmodels to replace the old toppings schema. - Added
don_customizesjoin model but missing composite key and has a naming mismatch.
Comments suppressed due to low confidence (2)
packages/backend/prisma/schema.prisma:35
- [nitpick] The field
topping_idrefers to thecustomizesmodel. Renaming it tocustomize_idwould align the name with the related model and improve clarity.
topping_id String @db.Uuid
packages/backend/prisma/schema.prisma:44
- The
@db.VarChar()attribute requires a length parameter (e.g.,@db.VarChar(255)). Please specify the maximum length for this column to avoid schema generation errors.
label String @db.VarChar()
Comment on lines
+34
to
+39
| don_id String @id @db.Uuid | ||
| topping_id String @db.Uuid | ||
| amount Int // 負も取りうる (0がデフォルト量) | ||
|
|
||
| model options { | ||
| id Int @id @default(autoincrement()) | ||
| label String @db.VarChar(255) | ||
| customize customizes @relation(fields: [topping_id], references: [id]) | ||
| don dons @relation(fields: [don_id], references: [id]) |
There was a problem hiding this comment.
The don_customizes model defines don_id as the sole primary key, which prevents associating multiple customizations with the same don. Consider removing @id from don_id and adding a composite primary key: @@id([don_id, topping_id]).
Copilot uses AI. Check for mistakes.
|
hikuohiku
approved these changes
Jul 4, 2025
| create_datetime DateTime @default(now()) | ||
| update_datetime DateTime @updatedAt | ||
| order orders @relation(fields: [order_id], references: [id]) | ||
| don_customizes don_customizes[] | ||
| } |
There was a problem hiding this comment.
stateを生やす
インデックス貼りたいですが、prisma schemaってindexも記載できるのでしたっけ？
| } | ||
| model don_customizes { | ||
| don_id String @id @db.Uuid | ||
| topping_id String @db.Uuid |
|
seed作り直したいですね。 |
|
作りました #176 |
…and order management
…nt-under-.api-from-prisma.schema Add OpenAPI components reflecting Prisma models
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112