Optimize RemoveInvalidServerResult

Author: 2dust

v2rayN/ServiceLib/Handler/ConfigHandler.cs

@@ -294,7 +294,7 @@ public static async Task<int> AddVMessServer(Config config, ProfileItem profileI
         /// <param name="config"></param>
         /// <param name="indexes"></param>
         /// <returns></returns>
-        public static async Task<int> RemoveServer(Config config, List<ProfileItem> indexes)
+        public static async Task<int> RemoveServers(Config config, List<ProfileItem> indexes)
         {
             var subid = "TempRemoveSubId";
             foreach (var item in indexes)
@@ -303,7 +303,7 @@ public static async Task<int> RemoveServer(Config config, List<ProfileItem> inde
             }
 
             await SQLiteHelper.Instance.UpdateAllAsync(indexes);
-            await RemoveServerViaSubid(config, subid, false);
+            await RemoveServersViaSubid(config, subid, false);
 
             return 0;
         }
@@ -886,7 +886,7 @@ public static async Task<Tuple<int, int>> DedupServerList(Config config, string
                     lstRemove.Add(item);
                 }
             }
-            await RemoveServer(config, lstRemove);
+            await RemoveServers(config, lstRemove);
 
             return new Tuple<int, int>(lstProfile.Count, lstKeep.Count);
         }
@@ -1062,12 +1062,9 @@ public static async Task<int> RemoveInvalidServerResult(Config config, string su
             var lstProfile = (from t in lstModel
                               join t2 in lstProfileExs on t.IndexId equals t2.IndexId
                               where t2.Delay == -1
-                              select t.IndexId).ToList();
+                              select t).ToList();
 
-            foreach (var item in lstProfile)
-            {
-                await RemoveProfileItem(config, item);
-            }
+            await RemoveServers(config, JsonUtils.Deserialize<List<ProfileItem>>(JsonUtils.Serialize(lstProfile)));
 
             return lstProfile.Count;
         }
@@ -1094,7 +1091,7 @@ private static async Task<int> AddBatchServersCommon(Config config, string strDa
             //remove sub items
             if (isSub && Utils.IsNotEmpty(subid))
             {
-                await RemoveServerViaSubid(config, subid, isSub);
+                await RemoveServersViaSubid(config, subid, isSub);
                 subFilter = (await AppHandler.Instance.GetSubItem(subid))?.Filter ?? "";
             }
 
@@ -1188,7 +1185,7 @@ private static async Task<int> AddBatchServers4Custom(Config config, string strD
             {
                 if (isSub && Utils.IsNotEmpty(subid))
                 {
-                    await RemoveServerViaSubid(config, subid, isSub);
+                    await RemoveServersViaSubid(config, subid, isSub);
                 }
                 int count = 0;
                 foreach (var it in lstProfiles)
@@ -1244,7 +1241,7 @@ private static async Task<int> AddBatchServers4Custom(Config config, string strD
 
             if (isSub && Utils.IsNotEmpty(subid))
             {
-                await RemoveServerViaSubid(config, subid, isSub);
+                await RemoveServersViaSubid(config, subid, isSub);
             }
 
             profileItem.Subid = subid;
@@ -1269,7 +1266,7 @@ private static async Task<int> AddBatchServers4SsSIP008(Config config, string st
 
             if (isSub && Utils.IsNotEmpty(subid))
             {
-                await RemoveServerViaSubid(config, subid, isSub);
+                await RemoveServersViaSubid(config, subid, isSub);
             }
 
             var lstSsServer = ShadowsocksFmt.ResolveSip008(strData);
@@ -1456,7 +1453,7 @@ public static async Task<int> AddSubItem(Config config, SubItem subItem)
         /// <param name="config"></param>
         /// <param name="subid"></param>
         /// <returns></returns>
-        public static async Task<int> RemoveServerViaSubid(Config config, string subid, bool isSub)
+        public static async Task<int> RemoveServersViaSubid(Config config, string subid, bool isSub)
         {
             if (Utils.IsNullOrEmpty(subid))
             {
@@ -1487,7 +1484,7 @@ public static async Task<int> DeleteSubItem(Config config, string id)
                 return 0;
             }
             await SQLiteHelper.Instance.DeleteAsync(item);
-            await RemoveServerViaSubid(config, id, false);
+            await RemoveServersViaSubid(config, id, false);
 
             return 0;
         }

v2rayN/ServiceLib/ViewModels/ProfilesViewModel.cs

@@ -520,7 +520,7 @@ public async Task RemoveServerAsync()
             }
             var exists = lstSelecteds.Exists(t => t.IndexId == _config.IndexId);
 
-            await ConfigHandler.RemoveServer(_config, lstSelecteds);
+            await ConfigHandler.RemoveServers(_config, lstSelecteds);
             NoticeHandler.Instance.Enqueue(ResUI.OperationSuccess);
             if (lstSelecteds.Count == _profileItems.Count)
             {